Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

tests/unit/core/models/test_summary.py (1)

29-29: ⚡ Quick win

Consider including execution_time in test fixture for completeness.

The fixture now sets evaluation_latency: 1.0 but doesn't set execution_time. Per the PR summary, execution_time is retained for backward compatibility and should equal evaluation_latency + agent_latency. Consider explicitly setting execution_time in the fixture to create realistic test data and verify the field is properly handled throughout the summary generation logic.

♻️ Suggested addition to fixture

 _RESULT_DEFAULTS: dict[str, Any] = {
     "conversation_group_id": "conv1",
     "tag": "eval",
     "turn_id": "turn1",
     "metric_identifier": "ragas:faithfulness",
     "result": "PASS",
     "score": 0.85,
     "threshold": 0.7,
     "reason": "Good",
     "evaluation_latency": 1.0,
+    "agent_latency": 0.5,
+    "execution_time": 1.5,
     "judge_llm_input_tokens": 100,
     "judge_llm_output_tokens": 50,
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/core/models/test_summary.py` at line 29, The test fixture in
tests/unit/core/models/test_summary.py sets "evaluation_latency" but omits
"execution_time"; update the fixture to include "execution_time" and set it
equal to evaluation_latency + agent_latency (so execution_time =
evaluation_latency + agent_latency) to match the PR behavior and ensure summary
generation and backward-compat checks (e.g., in any assertions referencing
execution_time) use realistic data.

tests/unit/core/storage/test_sql_storage.py (1)

53-53: ⚡ Quick win

Consider setting execution_time in test fixture for backward compatibility verification.

The fixture sets evaluation_latency=1.5 but doesn't set execution_time or agent_latency. Per the PR summary and line 428 of this file, execution_time is retained as a DB column for backward compatibility. The test fixture should either:

1. Explicitly set execution_time to verify it's stored correctly, or
2. Verify the model auto-computes execution_time = evaluation_latency + agent_latency

Without this, tests may not catch issues where execution_time is NULL or incorrectly computed.

♻️ Suggested fixture enhancement

     return EvaluationResult(
         conversation_group_id="conv_001",
         tag="test",
         turn_id="turn_1",
         metric_identifier="ragas:faithfulness",
         metric_metadata='{"threshold": 0.8}',
         result="PASS",
         score=0.95,
         threshold=0.8,
         reason="Good response",
         query="What is Python?",
         response="Python is a programming language.",
         evaluation_latency=1.5,
+        agent_latency=0.0,
+        execution_time=1.5,
         api_input_tokens=100,
         api_output_tokens=50,
     )

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/core/storage/test_sql_storage.py` at line 53, The test fixture in
tests/unit/core/storage/test_sql_storage.py currently sets
evaluation_latency=1.5 but omits execution_time and agent_latency; update the
fixture (the evaluation row/setup used in the tests) to either explicitly set
execution_time (e.g., execution_time=<expected value>) to verify DB persistence,
or set agent_latency and then add an assertion in the relevant test that
execution_time == evaluation_latency + agent_latency so the code path that
computes/stores execution_time is exercised; refer to the fields execution_time,
evaluation_latency, and agent_latency when making the change.

tests/unit/core/models/test_data.py (1)

472-472: ⚡ Quick win

Add an execution_time default assertion to the test
EvaluationResult.execution_time is defined with default=0.0 alongside evaluation_latency=0.0; extend tests/unit/core/models/test_data.py (line 472) to assert result.execution_time == 0.0 in addition to result.evaluation_latency == 0.0.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/core/models/test_data.py` at line 472, The test currently asserts
result.evaluation_latency == 0 but misses the sibling default; add an assertion
for EvaluationResult.execution_time by verifying result.execution_time == 0.0
immediately alongside the existing evaluation_latency check (i.e., update the
test that references result to include result.execution_time == 0.0).